Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: Add custom rpmlint config #5926

Merged
merged 2 commits into from
Oct 22, 2024
Merged

infra: Add custom rpmlint config #5926

merged 2 commits into from
Oct 22, 2024

Conversation

elkoniu
Copy link
Contributor

@elkoniu elkoniu commented Oct 8, 2024

Custom rpmlint config file is merged with default config. This way we can supress some errors which are inrelevant to our project.

@github-actions github-actions bot added the f42 Fedora 42 label Oct 8, 2024
@elkoniu
Copy link
Contributor Author

elkoniu commented Oct 8, 2024

This is very basic but also safe change to default rpmlint config. It wont fix all the issues but will get rid of identified false positives (for now).

@elkoniu
Copy link
Contributor Author

elkoniu commented Oct 8, 2024

Just for the record, here is sample of current F41 dist git rpmlint run:

===================================================== rpmlint session starts ====================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 17

anaconda.src: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage')
anaconda.x86_64: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage')
anaconda-dracut.x86_64: E: spelling-error ('kickstarts', '%description -l en_US kickstarts -> kick starts, kick-starts, kicks tarts')
anaconda-install-env-deps.x86_64: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage')
anaconda-install-img-deps.x86_64: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage')
anaconda-install-img-deps.x86_64: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so')
anaconda-install-img-deps.x86_64: E: spelling-error ('eg', '%description -l en_US eg -> eh, e, g')
anaconda-install-img-deps.x86_64: E: spelling-error ('lorax', '%description -l en_US lorax -> borax')
anaconda-core-debuginfo.x86_64: W: only-non-binary-in-usr-lib
anaconda-core.x86_64: W: obsolete-not-provided booty
anaconda-core.x86_64: W: no-manual-page-for-binary anaconda-cleanup
anaconda-core.x86_64: W: no-manual-page-for-binary anaconda-disable-nm-ibft-plugin
anaconda-core.x86_64: W: no-manual-page-for-binary anaconda-nm-disable-autocons
anaconda-core.x86_64: W: no-manual-page-for-binary instperf
anaconda-core.x86_64: W: no-manual-page-for-binary anaconda
anaconda-core.x86_64: W: no-manual-page-for-binary handle-sshpw
anaconda.x86_64: W: no-documentation
anaconda-core.x86_64: W: no-documentation
anaconda-dracut.x86_64: W: no-documentation
anaconda-gui.x86_64: W: no-documentation
anaconda-install-env-deps.x86_64: W: no-documentation
anaconda-install-img-deps.x86_64: W: no-documentation
anaconda-tui.x86_64: W: no-documentation
anaconda-widgets.x86_64: W: no-documentation
anaconda.x86_64: E: no-binary
anaconda-core-debuginfo.x86_64: E: no-binary
anaconda-install-env-deps.x86_64: E: no-binary
anaconda-install-img-deps.x86_64: E: no-binary
anaconda.spec:1954: W: macro-in-%changelog %post
anaconda.spec:2712: W: macro-in-%changelog %anaconda
anaconda.spec:1954: W: macro-in-%changelog %post
anaconda.spec:2712: W: macro-in-%changelog %anaconda
anaconda-core.x86_64: E: explicit-lib-dependency flatpak-libs
anaconda-core.x86_64: E: explicit-lib-dependency libselinux-python3
anaconda-install-env-deps.x86_64: E: explicit-lib-dependency libblockdev-lvm-dbus
anaconda-install-img-deps.x86_64: E: explicit-lib-dependency librsvg2
anaconda-gui.x86_64: W: dangling-symlink /usr/share/anaconda/window-manager/glib-2.0/schemas/org.gnome.desktop.enums.xml /usr/share/glib-2.0/schemas/org.gnome.desktop.enums.xml
anaconda-gui.x86_64: W: dangling-symlink /usr/share/anaconda/window-manager/glib-2.0/schemas/org.gnome.desktop.wm.keybindings.gschema.xml /usr/share/glib-2.0/schemas/org.gnome.desktop.wm.keybindings.gschema.xml
anaconda-gui.x86_64: W: dangling-symlink /usr/share/anaconda/window-manager/glib-2.0/schemas/org.gnome.desktop.wm.preferences.gschema.xml /usr/share/glib-2.0/schemas/org.gnome.desktop.wm.preferences.gschema.xml
anaconda-core.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/bb/8e8a1aec980e68bcfae6ac362ebae9d7c08e0a ../../../../usr/libexec/anaconda/dd_extract
anaconda-core.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/f2/cceaadfee0078433b2d6dd2cb08ec49fd217bc ../../../../usr/libexec/anaconda/dd_list
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/anaconda.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/conf.d/00-do-nothing.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/conf.d/01-still-do-nothing.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/conf.d/README
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/almalinux.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/centos.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/circle.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-designsuite.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-eln.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-iot.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-kde.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-kinoite.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-sericea.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-server.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-silverblue.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora-workstation.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/fedora.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/ovirt.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/rhel.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/rhvh.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/rocky.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/scientific-linux.conf
anaconda-core.x86_64: W: conffile-without-noreplace-flag /etc/anaconda/profile.d/virtuozzo-linux.conf
============= 16 packages and 1 specfiles checked; 16 errors, 48 warnings, 96 filtered, 16 badness; has taken 2.4 s =============

KKoukiou
KKoukiou reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test it? I think you can create a dist-git PR , (which you will not merge) and let the tests run to see if the errors get whitelisted with this.

@M4rtinK
Copy link
Contributor

M4rtinK commented Oct 9, 2024

How did you test it? I think you can create a dist-git PR , (which you will not merge) and let the tests run to see if the errors get whitelisted with this.

Yep, this should work and we definitely used it in the past to test similar changes. :)

@elkoniu elkoniu force-pushed the add-custom-rpmlint-config branch 2 times, most recently from 56ad2ff to 4cf8137 Compare October 15, 2024 02:13
@KKoukiou
Copy link
Contributor

/kickstart-tests --testtype smoke

jkonecny12
jkonecny12 reviewed Oct 15, 2024
View reviewed changes
anaconda.spec.in Outdated Show resolved Hide resolved
@elkoniu
infra: Add custom rpmlint config
b31182e 
Custom rpmlint config file is merged with default config.
This way we can supress some errors which are inrelevant to our project.
@elkoniu
Update spec config files list
02a1f20 
Anaconda uses multiple configuration files stored in /etc
This commit marks two locations used by anaconda as config:
- /etc/pam.d/anaconda
- /etc/xdg/autostart/*.desktop
jkonecny12
jkonecny12 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jkonecny12
Copy link
Member

/kickstart-test --waive infra only

@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

@jkonecny12 jkonecny12 merged commit a615ad5 into rhinstaller:master Oct 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
f42 Fedora 42
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elkoniu @M4rtinK @KKoukiou @jkonecny12