Commits on Oct 16, 2024

1. Fix crash on continue after a missing package non-critical error …

   Due to the way how exceptions propagate from the Anaconda installation tasks we ended
   up with a non-critical error exception interrupting the iteration of an important task
   iteration loop installing the payload.
   
   Due to not being handled "deep enough" but instead "bubbling up" to a top level
   error handler the loop apparently gets interrupted & remaining tasks
   skipped.
   
   This resulted in an unrelated crash ("kernel version list no available")
   due to all the important installation tasks being skipped, packages not
   being installed and installation related data not being populated.
   
   The end result was that a non-critical error (such as a missing package)
   would trigger a dialog asking the user to quit or continue - but clicking
   "continue" would result in a weird crash.
   
   So move the error handler check closer to the task execution, to
   prevent the loop from being interrupted. That way the loop will resume
   its iteration if "continue" is clicked in the UI.
   
   Also convert the non-critical error if it gets raised (user deciding
   *not* to continue after the non-critical error) to a fatal one. This is
   necessary, as otherwise the top level error handler would get triggered,
   asking the user again to quit or continue.
   
   NOTE: Longer term we really should clean this up & have all installation
   tasks gathered, ordered and executed from a single place. Then all the
   error handling could be in a single place, making things much simpler.
   
   (cherry picked from commit 73b412f)
   
   Resolves: RHEL-57699
   Resolves: INSTALLER-4045
   Related: rhbz#2238045

   

   M4rtinK committed Oct 16, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 0f6517b
   • Browse repository at this point

   Copy the full SHA

   0f6517b View commit details

   Browse the repository at this point in the history