-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edns certs stage2 w initramfs r10 #6082
base: rhel-10
Are you sure you want to change the base?
Edns certs stage2 w initramfs r10 #6082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me code wise.
However, it has wrong Resolves in the commit message.
Optional, you may want to change the license headers to 2025 🎉
509aa47
to
a4f945c
Compare
Kickstart %certificate section is used. Submodule, data structures, parsing. Resolves: RHEL-61434 Patch modified by rvykydal.
Unlike the %packages section where the data of all sections are merged into single data object the %certificates section holds the per instance section data in a list. Resolves: RHEL-61434
Resolves: RHEL-61434
Related: RHEL-61434
The certificates imported in initramfs are already imported earlier by a service. Resolves: RHEL-61434
Resolves: RHEL-61434
Resolves: RHEL-61434
In case they are needed or processed by package scriptlets Resolves: RHEL-61434
Resolves: RHEL-61434
Resolves: RHEL-61434
Don't require it on parsing level, don't own a default. Resolves: RHEL-61434
Resolves: RHEL-61434
Also dump for transfer durig switchroot so that the certificates can be potentially imported early after switchroot by a service. Resolves: RHEL-61434
Resolves: RHEL-61434
a4f945c
to
3714051
Compare
/kickstart-test --testtype smoke |
Updated |
Resolves: RHEL-61434
For example when --dir is pointing to read-only filesystem. Resolves: RHEL-61434
7010c7e
to
80c2a46
Compare
Added a separate commit (to make the port review easier) with fix that goes separately into main (#6097). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Port of #6045
The only difference from the upstream PR is import statements cleanup happened there.
TODO: