Update anaconda variables source #6129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
da1b81c to
ea36cd9
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
ea36cd9 to
3aac39d
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
3aac39d to
a1822df
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
a1822df to
d4d7148
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
d4d7148 to
8bb1c48
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
8bb1c48 to
72a2c20
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
72a2c20 to
e1ea1cc
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
Anaconda IsFinal property use to be processed out of ANACONDA_ISFINAL environmental variable. This commit changes this behaviour to use RELEASE_TYPE variable out of /etc/os-release instead. Related change in Fedora spec file: - https://src.fedoraproject.org/rpms/fedora-release/pull-request/347 Resolves: INSTALLER-4068
elkoniu
force-pushed
the
IsFInal-property-change
branch
from
e1ea1cc to
c7ceeed
Compare
elkoniu
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
jkonecny12
requested changes
Feb 3, 2025
There was a problem hiding this comment.
You should probably also change:
https://github.com/rhinstaller/anaconda/blob/main/data/liveinst/liveinst#L83
also comment a few lines above
3) Environment variable ANACONDA_ISFINAL
|
Also @bcl, isn't the |
In lorax the osbuild-composer operates the same way, setting IsFinal in .buildstamp and has no references to the variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anaconda IsFinal property use to be processed out of ANACONDA_ISFINAL environmental variable. This commit changes this behaviour to use RELEASE_TYPE variable out of /etc/os-release instead.
Resolves: INSTALLER-4068