Use bigger disk for fedora-live-image-build test (gh1248) #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstodola
reviewed
Jul 17, 2024
fedora-live-image-build.sh
Outdated
| prepare_disks() { | ||
| tmpdir=$1 | ||
|
|
||
| qemu-img create -q -f qcow2 ${tmpdir}/disk-a.img 12G |
There was a problem hiding this comment.
AFAIK, qemu-img doesn't allocate the specified image size on the disk when creating it. Because of that I think the disk size should be defined even bigger (20G?), just to prevent having to increase the value in the near future again. I do not expect the size of the image will stop increasing :-)
There was a problem hiding this comment.
I agree, let's take a benefit of the qcow2 format.
The test started to fail with "Not enough space in file systems for the current software selection. An additional 700 MiB is needed."
rvykydal
force-pushed
the
update-fedora-live-image-build-test
branch
from
4d3b205
to
bcdaeb0
Compare
|
/test-os-variants |
|
/test-tmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test started to fail with "Not enough space in file systems for the current software selection. An additional 700 MiB is needed."