Show stdout and stderr when virt-install fails #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the output is suppressed because we are showing only exception
but not it's stdout and stderr content. That could be really valuable
when debugging virt-install issues.
New output:
2024-07-17 15:14:20,164 INFO: RESULT:keyboard:b9624d95066a:FAILED:
Problem starting virtual install: Command '['virt-install', '-n', 'kstest-keyboard_(4922e9d9-157a-4eb7-8c00-7d169edba38b)', '-r', '2048', '--noautoconsole', '--vcpus', '1', '--rng', '/dev/random', '--osinfo', 'require=off,detect=on', '--graphics', 'vnc,listen=0.0.0.0', '--video', 'virtio', '--initrd-inject', '/opt/kstest/kickstart-tests/keyboard.ks', '--disk', 'path=/var/tmp/kstest-keyboard.2024_07_17-15_14_12.3c4e43xh/disk-a.img,cache=unsafe,bus=virtio', '--network', 'user,model=virtio', '--disk', 'path=/var/tmp/kstest-keyboard.2024_07_17-15_14_12.3c4e43xh/boot.iso,device=cdrom,readonly=on,shareable=on', '--boot', 'uefi', '--channel', 'tcp,host=127.0.0.1:36781,mode=connect,target_type=virtio,name=org.fedoraproject.anaconda.log.0']' returned non-zero exit status 1.
stdout: ERROR Install method does not support initrd injections.
stderr:
/var/tmp/kstest-keyboard.2024_07_17-15_14_12.3c4e43xh
vojtechtrefny
approved these changes
Jul 17, 2024
|
/test-tmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the output is suppressed because we are showing only exception but not it's stdout and stderr content. That could be really valuable when debugging virt-install issues.
New output:
2024-07-17 15:14:20,164 INFO: RESULT:keyboard:b9624d95066a:FAILED: Problem starting virtual install: Command '['virt-install', '-n', 'kstest-keyboard_(4922e9d9-157a-4eb7-8c00-7d169edba38b)', '-r', '2048', '--noautoconsole', '--vcpus', '1', '--rng', '/dev/random', '--osinfo', 'require=off,detect=on', '--graphics', 'vnc,listen=0.0.0.0', '--video', 'virtio', '--initrd-inject', '/opt/kstest/kickstart-tests/keyboard.ks', '--disk', 'path=/var/tmp/kstest-keyboard.2024_07_17-15_14_12.3c4e43xh/disk-a.img,cache=unsafe,bus=virtio', '--network', 'user,model=virtio', '--disk', 'path=/var/tmp/kstest-keyboard.2024_07_17-15_14_12.3c4e43xh/boot.iso,device=cdrom,readonly=on,shareable=on', '--boot', 'uefi', '--channel', 'tcp,host=127.0.0.1:36781,mode=connect,target_type=virtio,name=org.fedoraproject.anaconda.log.0']' returned non-zero exit status 1.
stdout: ERROR Install method does not support initrd injections.
stderr:
/var/tmp/kstest-keyboard.2024_07_17-15_14_12.3c4e43xh