Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an UEFI test (reboot-uefi) to coverage and smoke groups #1321

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add an UEFI test (reboot-uefi) to coverage and smoke groups #1321

merged 1 commit into from
Oct 17, 2024

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Oct 15, 2024 •
edited
Loading

Resolves: INSTALLER-4061
A modification of reboot test.

@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal
Copy link
Contributor Author

/test-os-variants --testtype smoke --skip-testtypes skip-on-rhel-10

@rvykydal
Copy link
Contributor Author

/test-tmt

jstodola
jstodola approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine.
If I should suggest an enhancement, it would be nice to check that the system is really running in UEFI mode - either during the installation or after reboot. Perhaps just a simple execution of efibootmgr should be enough (it fails on non-UEFI systems).

@rvykydal
Copy link
Contributor Author

I should mention that this is a modification of reboot test.

@rvykydal rvykydal force-pushed the add-uefi-test-to-coverage-and-smoke-groups branch from a207c03 to dcf35cf Compare October 16, 2024 10:17
@rvykydal rvykydal force-pushed the add-uefi-test-to-coverage-and-smoke-groups branch from dcf35cf to 2f6b78f Compare October 17, 2024 07:30
@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal
Copy link
Contributor Author

/test-tmt

@rvykydal
Copy link
Contributor Author

It looks fine. If I should suggest an enhancement, it would be nice to check that the system is really running in UEFI mode - either during the installation or after reboot. Perhaps just a simple execution of efibootmgr should be enough (it fails on non-UEFI systems).

@jstodola updated

jstodola
jstodola approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks.

jkonecny12
jkonecny12 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@rvykydal rvykydal merged commit 85f0856 into rhinstaller:master Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstodola jstodola jstodola approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@M4rtinK M4rtinK Awaiting requested review from M4rtinK

@KKoukiou KKoukiou Awaiting requested review from KKoukiou

@jikortus jikortus Awaiting requested review from jikortus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvykydal @jkonecny12 @jstodola