Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing store lazy header parameterisation #707

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fixing store lazy header parameterisation #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions resources/services/observatorium-metrics-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,7 +2912,7 @@ objects:
- --store.grpc.touched-series-limit=${THANOS_STORE_SERIES_TOUCHED_LIMIT}
- --store.grpc.series-sample-limit=${THANOS_STORE_SERIES_SAMPLE_LIMIT}
- --max-time=${THANOS_STORE_MAX_TIME}
- --store.enable-index-header-lazy-reader=${THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER}
- --store.enable-index-header-lazy-reader
env:
- name: OBJSTORE_CONFIG
valueFrom:
Expand Down Expand Up @@ -3170,7 +3170,7 @@ objects:
- --store.grpc.touched-series-limit=${THANOS_STORE_SERIES_TOUCHED_LIMIT}
- --store.grpc.series-sample-limit=${THANOS_STORE_SERIES_SAMPLE_LIMIT}
- --max-time=${THANOS_STORE_MAX_TIME}
- --store.enable-index-header-lazy-reader=${THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER}
- --store.enable-index-header-lazy-reader
env:
- name: OBJSTORE_CONFIG
valueFrom:
Expand Down Expand Up @@ -3428,7 +3428,7 @@ objects:
- --store.grpc.touched-series-limit=${THANOS_STORE_SERIES_TOUCHED_LIMIT}
- --store.grpc.series-sample-limit=${THANOS_STORE_SERIES_SAMPLE_LIMIT}
- --max-time=${THANOS_STORE_MAX_TIME}
- --store.enable-index-header-lazy-reader=${THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER}
- --store.enable-index-header-lazy-reader
env:
- name: OBJSTORE_CONFIG
valueFrom:
Expand Down Expand Up @@ -3686,7 +3686,7 @@ objects:
- --store.grpc.touched-series-limit=${THANOS_STORE_SERIES_TOUCHED_LIMIT}
- --store.grpc.series-sample-limit=${THANOS_STORE_SERIES_SAMPLE_LIMIT}
- --max-time=${THANOS_STORE_MAX_TIME}
- --store.enable-index-header-lazy-reader=${THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER}
- --store.enable-index-header-lazy-reader
env:
- name: OBJSTORE_CONFIG
valueFrom:
Expand Down Expand Up @@ -3944,7 +3944,7 @@ objects:
- --store.grpc.touched-series-limit=${THANOS_STORE_SERIES_TOUCHED_LIMIT}
- --store.grpc.series-sample-limit=${THANOS_STORE_SERIES_SAMPLE_LIMIT}
- --max-time=${THANOS_STORE_MAX_TIME}
- --store.enable-index-header-lazy-reader=${THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER}
- --store.enable-index-header-lazy-reader
env:
- name: OBJSTORE_CONFIG
valueFrom:
Expand Down Expand Up @@ -4202,7 +4202,7 @@ objects:
- --store.grpc.touched-series-limit=${THANOS_STORE_SERIES_TOUCHED_LIMIT}
- --store.grpc.series-sample-limit=${THANOS_STORE_SERIES_SAMPLE_LIMIT}
- --max-time=${THANOS_STORE_MAX_TIME}
- --store.enable-index-header-lazy-reader=${THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER}
- --store.enable-index-header-lazy-reader
env:
- name: OBJSTORE_CONFIG
valueFrom:
Expand Down Expand Up @@ -4621,8 +4621,6 @@ parameters:
value: "5"
- name: THANOS_STORE_MAX_TIME
value: "9999-12-31T23:59:59Z"
- name: THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER
value: "false"
- name: CONFIGMAP_RELOADER_IMAGE
value: quay.io/openshift/origin-configmap-reloader
- name: CONFIGMAP_RELOADER_IMAGE_TAG
Expand Down
2 changes: 1 addition & 1 deletion services/observatorium-metrics-template-overwrites.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ local thanosRuleSyncer = import './sidecars/thanos-rule-syncer.libsonnet';
'--store.grpc.touched-series-limit=${THANOS_STORE_SERIES_TOUCHED_LIMIT}',
'--store.grpc.series-sample-limit=${THANOS_STORE_SERIES_SAMPLE_LIMIT}',
'--max-time=${THANOS_STORE_MAX_TIME}',
'--store.enable-index-header-lazy-reader=${THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER}',
'--store.enable-index-header-lazy-reader',
],
} else c
for c in super.containers
Expand Down
1 change: 0 additions & 1 deletion services/observatorium-metrics-template.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ local obs = import 'observatorium.libsonnet';
{ name: 'THANOS_STORE_MEMORY_REQUEST', value: '1Gi' },
{ name: 'THANOS_STORE_REPLICAS', value: '5' },
{ name: 'THANOS_STORE_MAX_TIME', value: '9999-12-31T23:59:59Z' },
{ name: 'THANOS_STORE_ENABLE_INDEX_HEADER_LAZY_READER', value: 'false' },
{ name: 'CONFIGMAP_RELOADER_IMAGE', value: 'quay.io/openshift/origin-configmap-reloader' },
{ name: 'CONFIGMAP_RELOADER_IMAGE_TAG', value: '4.5.0' },
],
Expand Down
Loading