mage: memcached for api gateway #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
force-pushed
the
rhobs-1157
branch
from
fbf41b3 to
33b2a89
Compare
philipgough
force-pushed
the
rhobs-1157
branch
from
33b2a89 to
b3f9d1a
Compare
| Labels: labels, | ||
| }, | ||
| Spec: appsv1.StatefulSetSpec{ | ||
| Replicas: &config.Replicas, |
There was a problem hiding this comment.
Could you work the image/rep/resource fields into templates.go? Would be easier to have unified place for doing things
There was a problem hiding this comment.
i can. i wonder do you think it is polluting the main things we need to change though, ie thanos? or you prefer the consistency?
There was a problem hiding this comment.
We can have sub-structs for the thanos ones. But yeah prefer to have things be consistent and in one place, for quick, small changes in future 🙂
saswatamcode
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.