Remove buggy or vector(0) from alerts (#29)

They were causing false positives.
rhobs · Sep 22, 2023 · c3b6062 · c3b6062
1 parent 1df7a85
commit c3b6062
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/jsonnet/lib/alerts.libsonnet b/jsonnet/lib/alerts.libsonnet
@@ -11,7 +11,7 @@
                 sum_over_time(obsctl_reloader_prom_rules_store_ops_total{status_code=~"5..|4..", %(obsctlReloaderSelector)s}[5m])
               /
                 sum(sum_over_time(obsctl_reloader_prom_rules_store_ops_total{%(obsctlReloaderSelector)s}[5m]))
-              ) or vector(0)
+              )
               > 0.10
             ||| % $._config,
             'for': '10m',
@@ -30,7 +30,7 @@
                 sum_over_time(obsctl_reloader_prom_rule_set_failures_total{reason!="rules_store_error", %(obsctlReloaderSelector)s}[5m])
               /
                 sum_over_time(obsctl_reloader_prom_rule_set_total{%(obsctlReloaderSelector)s}[5m])
-              ) or vector(0)
+              )
               > 0.10
             ||| % $._config,
             'for': '10m',
@@ -49,7 +49,7 @@
                 sum_over_time(obsctl_reloader_prom_rule_fetch_failures_total{%(obsctlReloaderSelector)s}[5m])
               /
                 sum_over_time(obsctl_reloader_prom_rule_fetches_total{%(obsctlReloaderSelector)s}[5m])
-              ) or vector(0)
+              )
               > 0.20
             ||| % $._config,
             'for': '5m',

diff --git a/openshift/alerts.yaml b/openshift/alerts.yaml
@@ -10,7 +10,7 @@ groups:
         sum_over_time(obsctl_reloader_prom_rules_store_ops_total{status_code=~"5..|4..", job="obsctl-reloader"}[5m])
       /
         sum(sum_over_time(obsctl_reloader_prom_rules_store_ops_total{job="obsctl-reloader"}[5m]))
-      ) or vector(0)
+      )
       > 0.10
     for: 10m
     labels:
@@ -24,7 +24,7 @@ groups:
         sum_over_time(obsctl_reloader_prom_rule_set_failures_total{reason!="rules_store_error", job="obsctl-reloader"}[5m])
       /
         sum_over_time(obsctl_reloader_prom_rule_set_total{job="obsctl-reloader"}[5m])
-      ) or vector(0)
+      )
       > 0.10
     for: 10m
     labels:
@@ -38,7 +38,7 @@ groups:
         sum_over_time(obsctl_reloader_prom_rule_fetch_failures_total{job="obsctl-reloader"}[5m])
       /
         sum_over_time(obsctl_reloader_prom_rule_fetches_total{job="obsctl-reloader"}[5m])
-      ) or vector(0)
+      )
       > 0.20
     for: 5m
     labels: