Skip to content

Commit

Permalink
fix: use thanos default port in service and containerPort
Browse files Browse the repository at this point in the history
Before thanos was only listening on localhost. Relying on the default
setting allows user to modify that via server side apply and add a proxy
chain.

Signed-off-by: Jan Fajerski <[email protected]>
  • Loading branch information
jan--f committed Feb 8, 2024
1 parent 4367a6e commit d99df05
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/controllers/monitoring/thanos-querier/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ func thanosComponentReconcilers(thanos *msoapi.ThanosQuerier, sidecarUrls []stri
func newThanosQuerierDeployment(name string, spec *msoapi.ThanosQuerier, sidecarUrls []string, thanosCfg ThanosConfiguration) *appsv1.Deployment {
args := []string{
"query",
"--grpc-address=127.0.0.1:10901",
"--http-address=127.0.0.1:9090",
"--log.format=logfmt",
"--query.replica-label=prometheus_replica",
"--query.auto-downsampling",
Expand Down Expand Up @@ -71,7 +69,7 @@ func newThanosQuerierDeployment(name string, spec *msoapi.ThanosQuerier, sidecar
Image: thanosCfg.Image,
Ports: []corev1.ContainerPort{
{
ContainerPort: 9090,
ContainerPort: 10902,
Name: "metrics",
},
},
Expand Down Expand Up @@ -116,7 +114,7 @@ func newService(name string, namespace string) *corev1.Service {
Spec: corev1.ServiceSpec{
Ports: []corev1.ServicePort{
{
Port: 9090,
Port: 10902,
Name: "http",
},
},
Expand Down

0 comments on commit d99df05

Please sign in to comment.