Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat: Thanos Querier to Thanos sidecar mTLS #509

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vyzigold
Copy link
Contributor

This adds mTLS to connections from Thanos Querier to Thanos Sidecar. The connection uses selfsigned certificates generated by code taken from CMO.

The PR is missing functionality for watching the certificate secrets and restarting pods when the secrets change to start using new certificates. My plan is to use similar approach as in this PR if it's accepted by reviewers #496 . (compute a hash of the secret and include them as environment variables in the pods to trigger the restarts). I'll get back to this once the PR I mentioned before merges or a different approach to restarting pods is found.

Copy link

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vyzigold
Once this PR has been reviewed and has the lgtm label, please assign slashpai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jun 11, 2024

Hi @vyzigold. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants