Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid trying to run UI plugins as root #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iNecas
Copy link
Contributor

@iNecas iNecas commented Sep 6, 2024

When trying to use the troubleshooting-panel UIPlugin, I was getting:

container has runAsNonRoot and image will run as root
(pod: "troubleshooting-panel-...
 container: troubleshooting-panel)'
 reason: CreateContainerConfigError

I guess it's because the troubleshooting panel is build without setting the non-root user https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/Dockerfile.

I'm not sure why anyone else wasn't hitting this issue… I was running this against OCP 4.16.

When trying to use the troubleshooting-panel UIPlugin, I was getting:

```
container has runAsNonRoot and image will run as root
(pod: "troubleshooting-panel-...
 container: troubleshooting-panel)'
 reason: CreateContainerConfigError
```
@iNecas iNecas requested a review from a team as a code owner September 6, 2024 14:10
@iNecas iNecas requested review from jan--f and JoaoBraveCoding and removed request for a team September 6, 2024 14:10
Copy link

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iNecas
Once this PR has been reviewed and has the lgtm label, please assign danielmellado for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 6, 2024

Hi @iNecas. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@simonpasquier
Copy link
Contributor

I would defer to @PeterYurkovich and @jgbernalp but I'm not sure why we would need to set the user id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants