Retry error message #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage that can be used to trace back the failing function without inpsecting the back trace. The message can be specified using the @Retry(custom_message='...') argument, and if omitted will default to the name of the function invoked. Unit tests updated accordingly.
Added myself to the AUTHORS.rst file 😄
…lock to be compatible with python <2.7
…ompatible with python <2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a small change to improve the meaningfulness of the string representation of a (failed) Attempt.
Now when serializing the
Attemptinstance (likely when catching aRetryErrorexception) the returned string contains a customizable message or, when not specified, the name of the function that was wrapped by@retry.I updated the unit tests as well to verify the correct behavior of the feature and of course checked that other functionalities were not affected.
P.s. I know I should have opened an issue first, but I thought it would be faster to just make a PR.