Skip to content

Commit

Permalink
Change the cloudwatch target's default period to 'auto' (grafana#347)
Browse files Browse the repository at this point in the history
A default of 1m causes problems for metrics which are recorded infrequently
(e.g. S3) and for visualising long time ranges.
  • Loading branch information
rhowe authored Sep 25, 2021
1 parent 0c49b36 commit 19b27b2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions grafonnet/cloudwatch.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @param statistic (default: `'Average'`)
* @param alias (optional)
* @param highResolution (default: `false`)
* @param period (default: `'1m'`)
* @param period (default: `'auto'`)
* @param dimensions (optional)
* @param id (optional)
* @param expression (optional)
Expand All @@ -28,7 +28,7 @@
statistic='Average',
alias=null,
highResolution=false,
period='1m',
period='auto',
dimensions={},
id=null,
expression=null,
Expand Down
4 changes: 2 additions & 2 deletions tests/cloudwatch/test_compiled.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"highResolution": false,
"metricName": "RequestCountPerTarget",
"namespace": "AWS/ApplicationELB",
"period": "1m",
"period": "auto",
"region": "eu-west-1",
"statistics": [
"Sum"
Expand All @@ -20,7 +20,7 @@
"highResolution": false,
"metricName": "RequestCountPerTarget",
"namespace": "AWS/ApplicationELB",
"period": "1m",
"period": "auto",
"region": "eu-west-1",
"statistics": [
"Average"
Expand Down

0 comments on commit 19b27b2

Please sign in to comment.