Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback errors (#101) #115

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Callback errors (#101) #115

merged 2 commits into from
Aug 8, 2022

Conversation

rhys-vdw
Copy link
Owner

@rhys-vdw rhys-vdw commented Aug 8, 2022

Temporary (maybe?) solution to #101

This prevents callbacks from harming the ECS tween progress. Still leaves the issue Sync and Run operations, when called from callbacks, will cause errors. But this may be desirable to prevent endless loops e.g.:

tween.OnUpdate(() => tween.Sync()); // sync triggers an OnUpdate callback

To prevent them from interrupting the systems.
@rhys-vdw rhys-vdw merged commit 4dae093 into main Aug 8, 2022
@rhys-vdw rhys-vdw deleted the 101-callback-errors branch August 8, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant