Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Integration #250

Merged
merged 6 commits into from
Jun 7, 2024
Merged

VS Code Integration #250

merged 6 commits into from
Jun 7, 2024

Conversation

elliot-huffman
Copy link
Collaborator

Please See issue #249 for details

Travis is no longer used.
GitHub Actions is what we use on this project.
Deep integrate VS Code so that it can attach its debugger, has extension recommendations for this project and has useful settings for TypeScript.
Migrated the old VS Code settings from the settings file to the workspace file.
Update the NPM ignore to match the project's current state.
Arrange it to be alphabetical.
@elliot-huffman elliot-huffman changed the title Vs code integration VS Code Integration Jun 7, 2024
Remove the standard wildcard YAML check as there are none on the root of the project.
Removed the GitHub prefix on the final YAML glob so that it checks for all YAML files, not just the ones in the GitHub folder since the intent was to check all YAML with prettier.
Update the legacy badge for greenkeeper with a NPM JS badge and a Unit Test badge.
The link wasn't operational, see the Shields IO docs on why it isn't (markdown wasn't supported for the auto linker):
https://shields.io/badges/npm-version
@elliot-huffman elliot-huffman self-assigned this Jun 7, 2024
@elliot-huffman elliot-huffman added the enhancement New feature or request label Jun 7, 2024
This was referenced Jun 7, 2024
@rhys-vdw
Copy link
Owner

rhys-vdw commented Jun 7, 2024

Seems reasonable. I usually exclude IDE stuff from repos, but in it's pretty safe to assume everyone is using VSCode (I certainly am).

@rhys-vdw rhys-vdw merged commit 7b60ae2 into master Jun 7, 2024
5 checks passed
@rhys-vdw rhys-vdw deleted the VS-Code-Integration branch June 7, 2024 06:29
@rhys-vdw rhys-vdw mentioned this pull request Jun 7, 2024
@elliot-huffman
Copy link
Collaborator Author

Seems reasonable. I usually exclude IDE stuff from repos, but in it's pretty safe to assume everyone is using VSCode (I certainly am).

I saw that you already had vs code config artifacts inside of the repo, so I sort of just upgraded them to the latest config state with best practices integrated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants