Refactor GH Action Workflows #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
elliot-huffman
commented
Jul 9, 2024
•
elliot-huffman
commented
- Refactor the GH Actions workflow to work properly and to have it run off the GitHub releases system.
- Ensure that the version being published matches the tags in the repository to prevent a scenario where the versions are out of sync.
- Ensure that Tests are run against all commits, regardless of the commit title.
Run the publish command only on package release in GitHub, forcing that a changelog is kept and that manual workflow dispatch is not used. NPM Version incrementation is not part of the workflow, you will need to ensure that the version is incremented manually.
All commits should be tested, no exceptions!
Prevent publishing the package if the version of the package doesn't match the requested tag.
elliot-huffman
added
bug
This was failing tests, that should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.