feat: Support configurable timeout-minutes on jobs #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNorth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR implements optional and configurable enforcement of the
timeout-minutesfield on Jobs. I'm aware that actionlint intends to limit the amount of configuration available, but feel this is a valid use case - as do others supporting it in issue #49. Regarding the maintainer's concerns around making such an implementation too opinionated, I hope that this approach can address.In the past I have consumed actionlint as a package into my own CLI and added the rule via the options, which worked great. However, I would like to see this out-the-box. It is particularly useful, for example, when adding actionlint to a required workflow via GitHub Rulesets. We can auto generate a config in the shared Workflow that checks that all jobs have the
timeout-minutesfield set, thus avoiding blowing up our Organisation's minutes budget.I believe the approach gives users the functionality that we want (particularly in corporate organisations), but without getting in the way of the tool's current use - similarly to the configurable runner labels.