Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preset name size #634

Merged

Conversation

CherifAmine
Copy link
Contributor

@CherifAmine CherifAmine commented May 4, 2023

Description

Enter a brief description of the bug being fixed.
Fix Preset name cannot exceed 64 characters

Changes Made

Describe the changes made to fix the bug

Closes Issue(s)

Related Issue(s)

#618

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GhaziTriki GhaziTriki merged commit 43d0071 into riadvice:develop May 4, 2023
@GhaziTriki
Copy link
Member

@CherifAmine We also need the constraint the respond properly from the back-end.

@GhaziTriki GhaziTriki added the component: presets Changes related to predefined settings or configurations. label May 4, 2023
@GhaziTriki GhaziTriki added this to the 0.14.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: presets Changes related to predefined settings or configurations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants