Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding Group & Default Language #851

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

hanazarraa
Copy link
Contributor

@hanazarraa hanazarraa commented Jul 31, 2023

Description

Enter a brief description of the bug being fixed.

Changes Made

apply branding preset and default language groups to create & join
Describe the changes made to fix the bug

Closes Issue(s)

Related Issue(s)

#786

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

@marwa-benhassine
Copy link
Contributor

This problem occurs when clicking on the room
image

@marwa-benhassine marwa-benhassine self-assigned this Jul 31, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
4.3% 4.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@hanazarraa hanazarraa requested a review from GhaziTriki July 31, 2023 10:21
@marwa-benhassine marwa-benhassine added the quality control: changes requested Approved (for when the QA testing team approves the changes) label Aug 1, 2023
@marwa-benhassine
Copy link
Contributor

This problem occurs when clicking on the room
image

allowModsToEjectCameras must be of type Boolean and a non null value

@GhaziTriki GhaziTriki requested review from fatenrakrouki123 and removed request for GhaziTriki and fatenrakrouki123 December 3, 2024 10:18
@GhaziTriki GhaziTriki added this to the v1.0.0-alpha-2 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality control: changes requested Approved (for when the QA testing team approves the changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants