Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security group #896

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Conversation

hanazarraa
Copy link
Contributor

@hanazarraa hanazarraa commented Aug 31, 2023

Description

Enter a brief description of the bug being fixed.

Changes Made

apply security preset group to create & join
Describe the changes made to fix the bug

Closes Issue(s)

Related Issue(s)

#786 #897

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

@marwa-benhassine marwa-benhassine added the quality control: changes requested Approved (for when the QA testing team approves the changes) label Aug 31, 2023
@marwa-benhassine
Copy link
Contributor

The join button is always displayed even the meeting is not started

@marwa-benhassine marwa-benhassine self-assigned this Aug 31, 2023
@marwa-benhassine
Copy link
Contributor

Cannot assign string to property BigBlueButton\Parameters\CreateMeetingParameters::$duration of type ?int search

@marwa-benhassine
Copy link
Contributor

marwa-benhassine commented Sep 1, 2023

1.the input password is displayed when the password settings active and/or inactive

Inactive
image
Active
image

The same result is displayed

image

2.When the password setting is active and not written in the presets, the input password should not be displayed.

@marwa-benhassine
Copy link
Contributor

Still the same problem as described above #896 (comment)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@marwa-benhassine
Copy link
Contributor

The input password should be displayed when joining

@marwa-benhassine
Copy link
Contributor

marwa-benhassine commented Sep 14, 2023

When creating a user with a common password, the user page does not stop loading

user

This video is an example of the error messages that should appear

mdp user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality control: changes requested Approved (for when the QA testing team approves the changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants