Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidenub: fix old-mx-snap-in sidenub location #46

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

vegaaa
Copy link

@vegaaa vegaaa commented Feb 4, 2025

This PR should fix the sidenub location issue for the old-mx-snap-in keyhole.
The issue was brought up here: #44

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos-keyboards ✅ Ready (Inspect) Visit Preview Feb 4, 2025 6:39pm

@rianadon
Copy link
Owner

rianadon commented Feb 6, 2025

Thanks for taking the time to fix the model! Do you have a picture of what it should look like afterwards?

I could've missed something, but after checking out your changes and re-building the sockets this is what the STEP file looked like:

image

which looks the same as it was before.

Sorry I forgot to respond to your earlier message in #44. I'll make some measurements of my switches and sockets when I have a chance and get back to you.

@vegaaa
Copy link
Author

vegaaa commented Feb 6, 2025

I hope the image you showed is with the old-mx keyhole
It should be possible to see that the alignement of the sidenub for the snap-in variants has changed from bottom aligned to top aligned. At least it is working localy for me.

Here are images from stepfiles created localy with my changes.

old-mx-snap-in (now aligned with the top of the keyhole)
Screenshot 2025-02-06 at 08 50 21
old-mx-snap-in-hotswap (now aligned with the top of the keyhole)
Screenshot 2025-02-06 at 08 50 55
old-mx (same as before)
Screenshot 2025-02-06 at 08 51 58
old-mx-hotswap (same as before)
Screenshot 2025-02-06 at 08 52 28

Here are images of the keyholes before my changes (only for snap-in variants)

old-mx-snap-in
Screenshot 2025-02-06 at 09 03 35
old-mx-snap-in-hotswap
Screenshot 2025-02-06 at 09 04 12

@rianadon
Copy link
Owner

Sorry! I misread your comments. For some reason I thought this would change all the generated models, but your changes only apply to the snap-in variants. Thanks for sending the screenshots.

The image I showed was the non-snap-in mx keyhole 🤦.

The changes look great though! Thanks again for investigating, and I'll get this merged now.

@rianadon rianadon merged commit 06984e1 into rianadon:main Feb 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants