fix: ignore nested object validation if the parent object does not exist

ribbon-studios · Oct 27, 2023 · 2c41fab · 2c41fab
1 parent aa2a308
commit 2c41fab
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/src/__tests__/index.spec.ts b/src/__tests__/index.spec.ts
@@ -29,7 +29,11 @@ describe('class(Validator)', () => {
         },
       });
 
-      expect(validator.check({})).toEqual(['"messages.hello" is not defined']);
+      expect(
+        validator.check({
+          messages: {},
+        })
+      ).toEqual(['"messages.hello" is not defined']);
     });
 
     it('should support any number of nested objects', () => {
@@ -49,7 +53,33 @@ describe('class(Validator)', () => {
         },
       });
 
-      expect(validator.check({})).toEqual(['"i18n.en.hello" is not defined']);
+      expect(
+        validator.check({
+          i18n: {
+            en: {},
+          },
+        })
+      ).toEqual(['"i18n.en.hello" is not defined']);
+    });
+
+    it('should ignore validation if a parent object does not exist', () => {
+      type Example = {
+        i18n: {
+          en: {
+            hello: string;
+          };
+        };
+      };
+
+      const validator = new Validator<Example>({
+        i18n: {
+          en: {
+            hello: [isDefined],
+          },
+        },
+      });
+
+      expect(validator.check({})).toEqual([]);
     });
 
     it('should support ensuring arrays exist', () => {

diff --git a/src/index.ts b/src/index.ts
@@ -50,7 +50,7 @@ export class Validator<T extends object> {
                 config: configItem,
               });
             }
-          } else {
+          } else if (innerValue) {
             stack.push({
               parentKey: innerKey,
               item: innerValue,