Fix to wait for final SMTP command before checking next one #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragoangel
changed the title
|
To note: after implementing this fix my ssl exporter stopped to throw any false positive responses that endpoint is down. For people who can't wait to get this merged I build own image: dragoangel/ssl-exporter:2.5.1 @ribbybibby please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
220-postsreen ESMTP Postfixand response to itEHLO proberbut it should wait final command220 postfix ESMTP Postfixand only after it sendEHLO prober.250 .*capability from the list, as STARTTLS capability can be in any place, we need check we have it in the list and check that we get all capabilities at same time.