Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve specs related to password protected keys #88

Merged
merged 3 commits into from
Sep 22, 2018
Merged

Improve specs related to password protected keys #88

merged 3 commits into from
Sep 22, 2018

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Aug 12, 2018

Write adapter unit tests involving password-protected keys, and prevent GPG Agent from caching passwords between tests. Fixes #87.

@skalee skalee changed the title Better specs for password protected keys Improve specs related to password protected keys Aug 12, 2018
@skalee skalee force-pushed the better-specs-for-password-protected-keys branch from dcf83e1 to 877d74f Compare August 12, 2018 06:39
@codecov
Copy link

codecov bot commented Aug 12, 2018 •
edited
Loading

Codecov Report

Merging #88 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%     
==========================================
  Files          37       37              
  Lines        1273     1297      +24     
==========================================
+ Hits         1270     1294      +24     
  Misses          3        3
Impacted Files Coverage Δ
spec/unit/adapters/gpgme_spec.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b05d87...3b0d4e0. Read the comment docs.

@skalee
Copy link
Contributor Author

skalee commented Aug 12, 2018

Weird test failure appears randomly, like in https://travis-ci.org/riboseinc/enmail/jobs/415038361. Both locally and in CI. I remember no issue like this before.

Besides, other failures are resulting from GnuPG software download errors, which seem random as well. Doing #66 will eventually help, but for now, let's wait untill their servers get back to normal.

@skalee skalee force-pushed the better-specs-for-password-protected-keys branch 7 times, most recently from abac3c0 to 826aaaa Compare August 14, 2018 17:04
@ronaldtse
Copy link
Contributor

@skalee merging this soon? Just re-ran the jobs.

@skalee skalee force-pushed the better-specs-for-password-protected-keys branch from 826aaaa to 175ba48 Compare September 19, 2018 19:20
@skalee
More tests involving password-protected keys
a354310 
Ensure that providing wrong password or no password when signing with
password-protected key really raises exception.

Critical in context of issue #87.
@skalee
Prevent GPG Agent from caching passwords
1b8e60f 
Without that, tests aren't independent from each other.

Critical in context of issue #87.
@skalee
Don't recreate GnuPG configuration if it exists
3b0d4e0
@skalee skalee force-pushed the better-specs-for-password-protected-keys branch from 175ba48 to 3b0d4e0 Compare September 22, 2018 18:13
@skalee
Copy link
Contributor Author

skalee commented Sep 22, 2018

I've changed nothing, but I rebased on top of current master and it works well now. I don't know why. Perhaps I've fixed something in matchers when I extracted them.

@skalee skalee merged commit 28584e3 into master Sep 22, 2018
@skalee skalee deleted the better-specs-for-password-protected-keys branch September 22, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skalee @ronaldtse