Merge pull request #69 from riboseinc/ribose-jeffreylau-49-compact

rubocop: Enable Style/CollectionCompact for consistent nil checks
riboseinc · Nov 9, 2023 · af460e8 · af460e8
2 parents 5c4946d + c2c6ae5
commit af460e8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/ci/rubocop.rails.yml b/ci/rubocop.rails.yml
@@ -497,6 +497,11 @@ Metrics/PerceivedComplexity:
     reader.
   Enabled: true
   Max: 7
+Style/CollectionCompact:
+  Description: Checks for places where custom logic on rejection nils from arrays
+    and hashes can be replaced with {Array,Hash}#{compact,compact!}.
+  StyleGuide: https://docs.rubocop.org/rubocop/cops_style.html#stylecollectioncompact
+  Enabled: true
 Style/ArgumentsForwarding:
   Enabled: true
 Gemspec/RequireMFA:

diff --git a/ci/rubocop.yml b/ci/rubocop.yml
@@ -494,6 +494,11 @@ Metrics/PerceivedComplexity:
     reader.
   Enabled: true
   Max: 7
+Style/CollectionCompact:
+  Description: Checks for places where custom logic on rejection nils from arrays
+    and hashes can be replaced with {Array,Hash}#{compact,compact!}.
+  StyleGuide: https://docs.rubocop.org/rubocop/cops_style.html#stylecollectioncompact
+  Enabled: true
 Style/ArgumentsForwarding:
   Enabled: true
 Gemspec/RequireMFA:

diff --git a/src/rubocop/rubocop.ribose.yml b/src/rubocop/rubocop.ribose.yml
@@ -61,6 +61,12 @@ Metrics/PerceivedComplexity:
     reader.
   Enabled: true
   Max: 7
+
+Style/CollectionCompact:
+  Description: Checks for places where custom logic on rejection nils from arrays and hashes can be replaced with {Array,Hash}#{compact,compact!}.
+  StyleGuide: https://docs.rubocop.org/rubocop/cops_style.html#stylecollectioncompact
+  Enabled: true
+
 Style/CollectionMethods:
   Enabled: false
 Style/TrailingCommaInArguments: