Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instrumenting implementation #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix instrumenting implementation #48

wants to merge 3 commits into from

Conversation

ErwanVP
Copy link
Collaborator

@ErwanVP ErwanVP commented Feb 4, 2025 •
edited
Loading

  • The recordErrorCounter must be incremented every time the consumer makes an error while consuming the event.
  • The currentMessageTimestamp counter should be implemented earlier, as this value is not visible in the event of an error loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneGuerlais EtienneGuerlais EtienneGuerlais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErwanVP @EtienneGuerlais