Ensure Taps version of OkJson is used to properly encode data #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taps uses a customized version of OkJson to exchange data between the client and server. This customized version silently converts symbols to strings as a convience (the original OkJson considers encoding symbols an error since symbols are not a type supported by JSON). Rack started using OkJson also to encode data but kept the original symantics. Since the Taps::Server inherits from Sinatra::Base, and Sinatra::Base includes Rack::Utils, and Rack::Utils is the namespace where Rack's version of OkJson is installed this means the Rack version is now being used by taps instead of the taps version. This means when symbols are encoded an error is generated. To restore the original behavior this patch explicility references the taps version of OkJson. This fixes issue ricardochimal#128.
|
👍 This would have fixed a lot of headaches |
|
I've created taps-taps gem which includes your fix. Thanks! |
|
@wijet - Your my hero for putting together a fork of this software with everybody's patches. It too useful of software to let die just because Heroku has moved away from it but didn't have time to maintain a fork myself. Thanks! |
|
ahh, I just used the ugly uninstall then reinstall rack hack to get around this. nice one @wijet ! |
joelvh
added a commit
to joelvh/taps2
that referenced
this pull request
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taps uses a customized version of OkJson to exchange data between the client
and server. This customized version silently converts symbols to strings
as a convience (the original OkJson considers encoding symbols an error since
symbols are not a type supported by JSON).
Rack started using OkJson also to encode data but kept the original symantics.
Since the Taps::Server inherits from Sinatra::Base, and Sinatra::Base includes
Rack::Utils, and Rack::Utils is the namespace where Rack's version of OkJson
is installed this means the Rack version is now being used by taps instead of
the taps version. This means when symbols are encoded an error is generated.
To restore the original behavior this patch explicility references the taps
version of OkJson.
This fixes issue #128.