Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up the end of the auction. #33

Closed
8 tasks done
ricardopacheco opened this issue Mar 15, 2024 · 1 comment · Fixed by #38
Closed
8 tasks done

Set up the end of the auction. #33

ricardopacheco opened this issue Mar 15, 2024 · 1 comment · Fixed by #38
Assignees
Labels
priority:high High priority status:done Done status type:improvement A suggestion for general improvements

Comments

@ricardopacheco
Copy link
Owner

ricardopacheco commented Mar 15, 2024

Summary 🔴

Setting up the auction completion involves defining the parameters and conditions that govern the conclusion of bidding activities. We will involve the integration of a notification system (via email) to inform participants about the imminent conclusion of the auction.

Additionally, the configuration should enable post-auction procedures, such as invoicing and notifications to winners and participants. Specific details are outlined in the checklist section.

Proposed / Possible solution 🔴

The project already has all the necessary convention and structure. We will only follow what is already established.

Checklist

Setup

  • Create resources to completion an auction.
    • When the auction is of the closed or standard auctions, the auction concludes when it reaches the final time (finished_at).
    • When the auction is of the penny type, it should be concluded when the timer reaches zero.
  • If there is a winner, set them as the victor and send an email notifying them of the win and providing next steps.
  • If there is no winner, and the auction received no bids, simply finalize it.
  • Regardless of whether there are winners/bids, we must calculate the auction statistics.

Notifications

  • When there is a winner, notify the winner and provide information about the next steps.
  • For remaining participants, inform them of another winner and display general auction statistics along with statistics specific to their participation.

Related issues

#4

@ricardopacheco ricardopacheco self-assigned this Mar 15, 2024
@ricardopacheco ricardopacheco converted this from a draft issue Mar 15, 2024
@ricardopacheco ricardopacheco moved this from Backlog to In progress in AuctionFunCore Mar 15, 2024
@ricardopacheco ricardopacheco moved this from In progress to In review in AuctionFunCore Apr 22, 2024
@ricardopacheco ricardopacheco added type:improvement A suggestion for general improvements status:in-review In Review status priority:high High priority labels Apr 22, 2024
@ricardopacheco
Copy link
Owner Author

The task in question took longer than planned because two problems were not noticed when designing it: The immutability of the database objects (rom-db) and the need to change the end data for penny auctions from each new bid.

For this reason, the initial estimate was wrong.

@ricardopacheco ricardopacheco added status:done Done status and removed status:in-review In Review status labels Apr 22, 2024
@ricardopacheco ricardopacheco moved this from In review to Done in AuctionFunCore Apr 22, 2024
@ricardopacheco ricardopacheco linked a pull request Apr 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority status:done Done status type:improvement A suggestion for general improvements
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant