Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AF-33] Set up the end of the auction #38

Merged
merged 2 commits into from
Apr 22, 2024
Merged

[AF-33] Set up the end of the auction #38

merged 2 commits into from
Apr 22, 2024

Conversation

ricardopacheco
Copy link
Owner

Summary 🔴

Setting up the auction completion involves defining the parameters and conditions that govern the conclusion of bidding activities. We will involve the integration of a notification system (via email) to inform participants about the imminent conclusion of the auction.

Additionally, the configuration should enable post-auction procedures, such as invoicing and notifications to winners and participants. The version 0.8.6 CHANGELOG contains all the details.

Proposed / Possible solution 🔴

  • For each type of existing auction, we create a specific completion operation for it.
  • For standard and closed auctions, where there is no change in the end date, we only use a simple scheduling in the background job.
  • For penny auctions, the end date is updated with each new bid. Therefore, once created, a date is added (according to the timer), and it is updated again with each new bid. Finalization is also done using a background job. To avoid conflicts with lots of unnecessary bidding and scheduling, we use sidekiq unique jobs to manage this.

@ricardopacheco ricardopacheco added type:improvement A suggestion for general improvements status:in-review In Review status priority:high High priority labels Apr 22, 2024
@ricardopacheco ricardopacheco self-assigned this Apr 22, 2024
@ricardopacheco ricardopacheco added status:done Done status and removed status:in-review In Review status labels Apr 22, 2024
@ricardopacheco ricardopacheco merged commit 1c49017 into main Apr 22, 2024
1 check passed
@ricardopacheco ricardopacheco deleted the AF-33 branch April 22, 2024 16:06
@ricardopacheco ricardopacheco linked an issue Apr 30, 2024 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority status:done Done status type:improvement A suggestion for general improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up the end of the auction.
1 participant