[AF-3] Create currencies #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopacheco
added
type:feature
|
I made a mistake in the PR and selected the wrong branch. I will close this PR and open another with the correct branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #3
Summary 🔴
This PR adds the necessary features for handle currencies. Additional add-ons are available in the changelog in version
0.6.1.Proposed / Possible solution 🔴
We made use of the money gem dependency to deal with financial values. They have a simple and standardized way of dealing with currencies and also conversions between them. We will use ISO 4217 to guide us regarding currencies and rules.
We did a refactoring unrelated to the main feature, which is adding automated tests for entities.
How to test 👮♂️
Start the related services, and open the console with the command bin/console. Here you can call the user repository, which will instantiate a user's balance using the money gem, and use the methods and possibilities available in the money gem's official documentation.
Risks / Impacts 🔴
Requirements for deployment 🔴