[AF-31] Prepare the core to run on frameworks #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopacheco
added
status:in-review
ricardopacheco
added
status:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31
Summary 🔴
This PR includes the necessary adjustments to load the core lib externally from ruby frameworks (or manual apps). It also includes updating the gems to the latest version. This create a
0.8.4version.Proposed / Possible solution 🔴
For frameworks to load core dependencies automatically via bundle, we need to place them in the gemspec file instead of the Gemfile (which will only contain development and testing dependencies).
How to test 👮♂️
This will be demonstrated in the api application that we are already making in another project. In this API, I will show you how to use the integrated core features. In core, no functionality was added/changed.
Risks / Impacts 🔴
Requirements for deployment 🔴