Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #33 (properly check read return) #34

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fixes #33 (properly check read return) #34

merged 1 commit into from
Sep 13, 2023

Conversation

safinaskar
Copy link

Fixes #33

@richox
Copy link
Owner

richox commented Aug 30, 2023

can we use std::io::Read::read_exact() instead?

@safinaskar
Copy link
Author

@richox, no. It will fail if buffer is bigger than remaining data in file

@richox richox merged commit c7f1a18 into richox:master Sep 13, 2023
1 check passed
@safinaskar safinaskar deleted the read branch November 6, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Produces incorrect output if input is pipe
2 participants
@safinaskar @richox