Skip to content

Commit

Permalink
lint: address fixme / W0511
Browse files Browse the repository at this point in the history
There are a few occurrences where code is being used to keep track of
possible improvements.  Many times these will go unnoticed for ages.

Let's either document the limitations that are affected by the
"TODO"s, or remove them because after quite some time, they were not
something that was attempted to be improved or fixed.

https://pylint.pycqa.org/en/latest/user_guide/messages/warning/fixme.html
Signed-off-by: Cleber Rosa <[email protected]>
  • Loading branch information
clebergnu committed Oct 23, 2024
1 parent 4770c14 commit 667f53b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions .pylintrc_utils
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,7 @@ disable=C0103,
R1729,
R1730,
R1732,
W0212,
W0511
W0212

[REPORTS]

Expand Down
1 change: 0 additions & 1 deletion avocado/utils/lv_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,6 @@ def vg_list(vg_name=None):
lines = lines[1:]
else:
return vgroups
# TODO: Optimize this
for line in lines:
details = line.split()
details_dict = {}
Expand Down
7 changes: 3 additions & 4 deletions avocado/utils/process.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,11 @@ def process_in_ptree_is_defunct(ppid):
Attempt to verify if parent process and any children from PPID is defunct
(zombie) or not.
This relies on the GNU version of "ps" and is not guaranteed to work in
MacOS.
:param ppid: The parent PID of the process to verify.
"""
# TODO: This relies on the GNU version of ps (need to fix MacOS support)
defunct = False
try:
pids = get_children_pids(ppid)
Expand Down Expand Up @@ -455,9 +457,6 @@ def __init__(
self.fd = fd
self.name = name
self.data = BytesIO()
# TODO: check if, when the process finishes, the FD doesn't
# automatically close. This may be used as the detection
# instead.
self._result = result
self._thread = None
self._logger = logger
Expand Down

0 comments on commit 667f53b

Please sign in to comment.