Skip to content

[안드] 듣기시 유효하지 않은 span태그 스킵하도록 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 18, 2025
Merged

[안드] 듣기시 유효하지 않은 span태그 스킵하도록 #41

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3c50c7
[안드] 공백만 있는 span태그 스킵하도록
Kyungtae-TEI Jan 9, 2025
87011b0
142, 143 테스트 케이스 실패하는 문제 대응
Kyungtae-TEI Jan 9, 2025
2e55b61
Array.from() 생성자가 null을 리턴해 테스트케이스 실패하는 문제
Kyungtae-TEI Jan 9, 2025
bb3759a
직전 커밋 테스트 실패하던 것 간소화된 방법으로 재대응
Kyungtae-TEI Jan 9, 2025
d7bf1d1
Revert "직전 커밋 테스트 실패하던 것 간소화된 방법으로 재대응"
Kyungtae-TEI Jan 9, 2025
9b143ee
[review] 코드 간소화
Kyungtae-TEI Feb 17, 2025
e5b1341
[review] 공백 관련 처리 범위 확대
Kyungtae-TEI Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/tts/TTSPiece.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export default class TTSPiece {
const readable = (el.attributes['data-ridi-tts'] || { value: '' }).value.toLowerCase();
let valid = true;

if (this.length === 0 || readable === 'no') {
if (this.length === 0 || el.innerText.trim().length === 0 || readable === 'no') {
valid = false;
} else if (readable !== 'yes') {
if (_Util.getMatchedCSSValue(el, 'display') === 'none'
Expand Down
Loading