Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more meta information & error handling #99

Merged
merged 3 commits into from
May 4, 2023

Conversation

nbrinckm
Copy link
Contributor

@nbrinckm nbrinckm commented May 4, 2023

We discussed yesterday that it could be helpful to have some more error handling support.

I think my pull request doesn't solve this exact problem, but I think it is still helpul to add the exception report in the jobs table (in case the WPS executation failed).
And I also add created_at fields, so that we know when the jobs/outputs where created.

Copy link
Member

@arnevogt arnevogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly makes sense to store the exception if a job ultimately fails.

I think this will only log the final exception when a job fails; don't know if there is an easy way to store every exception for every retry. In issue #98 it seems to be the case that the WPS is stuck after n retries.

Copy link
Contributor

@MichaelLangbein MichaelLangbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Can be merged if you're content with it.
Will need need to read those in the frontend as well. I've added a note to issue #81 .

@nbrinckm
Copy link
Contributor Author

nbrinckm commented May 4, 2023

Certainly makes sense to store the exception if a job ultimately fails.

I think this will only log the final exception when a job fails; don't know if there is an easy way to store every exception for every retry. In issue #98 it seems to be the case that the WPS is stuck after n retries.

It will set the exception stacktrace in the moment that we consider the wps call as failed anyway.

In case we have the retry for the wps call itself, it can be the last one after the retries (so network related in this case).
If it would be one of the exceptions that we don't consider for retrying we would store the stacktrace of those exception.

It it is stuck in the retry somehow & we don't consider the job as failed so far, then we still don't save this exception stacktrace. We simply don't get them for the moment - so storing it is not possible yet.

@nbrinckm nbrinckm merged commit 4455f5b into main May 4, 2023
@MichaelLangbein MichaelLangbein deleted the add-more-meta-information branch July 19, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants