Skip the boot disk on gce during backup #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should be a unit test that tests this functionality. |
douglaswth
added a commit
that referenced
this pull request
Mar 12, 2014
…_skip_boot_disk_in_gce_during_backup_create Skip the boot disk on gce during backup
douglaswth
deleted the
white_14_03_acu114920_skip_boot_disk_in_gce_during_backup_create
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gce, the boot disk is a persistent disk and the
:createaction onrightscale_backupresource also backs up this boot device. Since there is no way of backing up specific devices (#2), we should at least skip the boot device.There seems to be a way to differentiate between boot disk and a regular disk. Here is the resource_uid of a boot disk:
and here is the resource_uid of a regular persistent disk: