Decomp: DvdArchive #189
Merged
Decomp: DvdArchive #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Various functions" refers to inlined/unused functions
mkwutil/verify_staticr_rel.py is also changed to prevent terminal flooding
DvdArchive::getFile now takes in size_t instead of s32 for size.
|
LGTM! Nice work :) |
riidefi
pushed a commit
that referenced
this pull request
Feb 25, 2024
* Decomp: DvdArchive ctor/dtor * [FAIL] Decomp: DvdArchive load, various functions "Various functions" refers to inlined/unused functions * Decomp: DvdArchive load, inlined/unused functions * Decomp: DvdArchive clear * Decomp: DvdArchive unmount * Decomp: DvdArchive getFile mkwutil/verify_staticr_rel.py is also changed to prevent terminal flooding * Decomp: DvdArchive load * Decomp: DvdArchive loadBuffer * Fix: DvdArchive getFile * Decomp: DvdArchive getFileCopy DvdArchive::getFile now takes in size_t instead of s32 for size. * Decomp: DvdArchive move * Decomp: DvdArchive tryRipFile * Decomp: DvdArchive ripFile * Decomp: DvdArchive decompress * Decomp: DvdArchive loadOther * Final: File cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #76, task 1.