Skip to content

Commit

Permalink
[fix](ub) Dont throw in noexcept function (apache#45672)
Browse files Browse the repository at this point in the history
  • Loading branch information
zclllyybb authored Dec 19, 2024
1 parent 55c26e0 commit 6c57c3c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions be/src/pipeline/exec/exchange_sink_buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,10 @@ class ExchangeSendCallback : public ::doris::DummyBrpcCallback<Response> {
start_rpc_time);
}
} catch (const std::exception& exp) {
throw Exception(Status::FatalError("brpc callback error: {}", exp.what()));
LOG(FATAL) << "brpc callback error: " << exp.what();
} catch (...) {
throw Exception(Status::FatalError("brpc callback error."));
LOG(FATAL) << "brpc callback error.";
__builtin_unreachable();
}
}
int64_t start_rpc_time;
Expand Down

0 comments on commit 6c57c3c

Please sign in to comment.