Merge pull request #25 from OLIOEX/develop

Fix getNumType method and add tests

src/PhoneInput.tsx

@@ -4,7 +4,7 @@ import {
 } from 'react-native';
 import Country from './country';
 import Flags from './resources/flags';
-import PhoneNumber from './phoneNumber';
+import PhoneNumber from './PhoneNumber';
 import styles from './styles';
 import CountryPicker from './CountryPicker';
 import { ReactNativePhoneInputProps } from './typings';

src/phoneNumber.tsx → src/PhoneNumber.tsx

@@ -103,8 +103,8 @@ class PhoneNumber {
 
     getNumberType(number, iso2) {
         const phoneInfo = this.parse(number, iso2);
-        const type = phoneInfo ? phoneUtil.getNumberType(phoneInfo) : -1;
-        return _.findKey((numType, noType) => noType === type);
+        const typeIndex = phoneInfo ? phoneUtil.getNumberType(phoneInfo) : -1;
+        return _.findKey(numberType, (noType) => noType === typeIndex);
     }
 
     // eslint-disable-next-line class-methods-use-this

src/index.tsx

@@ -2,4 +2,5 @@ import PhoneInput from './PhoneInput';
 
 export { default as CountryPicker } from './CountryPicker';
 export { default as CountryList } from './resources/countries.json';
+export { default as PhoneNumber } from './PhoneNumber';
 export default PhoneInput;

tests/PhoneNumber.test.ts

@@ -0,0 +1,25 @@
+import { expect } from 'chai';
+import PhoneNumber from '../src/PhoneNumber';
+
+describe('getNumberType', () => {
+  it('returns UNKNOWN type', () => {
+    const number = '+44000';
+    const iso2 = 'gb';
+    const numberType = PhoneNumber.getNumberType(number, iso2);
+    expect(numberType).to.equal('UNKNOWN');
+  });
+
+  it('returns MOBILE type', () => {
+    const number = '+447900000001';
+    const iso2 = 'gb';
+    const numberType = PhoneNumber.getNumberType(number, iso2);
+    expect(numberType).to.equal('MOBILE');
+  });
+
+  it('returns FIXED_LINE type', () => {
+    const number = '+442072212217';
+    const iso2 = 'gb';
+    const numberType = PhoneNumber.getNumberType(number, iso2);
+    expect(numberType).to.equal('FIXED_LINE');
+  });
+});