Add option to force 0 based origin

rilldata · Feb 7, 2025 · 6f3ecdb · 6f3ecdb
1 parent f92f052
commit 6f3ecdb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/web-common/src/features/canvas/components/charts/builder.ts b/web-common/src/features/canvas/components/charts/builder.ts
@@ -69,9 +69,11 @@ export function createYEncoding(
     field: sanitizeValueForVega(config.y.field),
     title: metaData?.displayName || config.y.field,
     type: config.y.type,
-    scale: {
-      zero: false,
-    },
+    ...(config.y.zeroBasedOrigin !== true && {
+      scale: {
+        zero: false,
+      },
+    }),
     axis: {
       ...(config.y.type === "quantitative" && {
         formatType: config.y.field,

diff --git a/web-common/src/features/canvas/components/charts/types.ts b/web-common/src/features/canvas/components/charts/types.ts
@@ -2,9 +2,8 @@ import type { ComponentType, SvelteComponent } from "svelte";
 
 export interface FieldConfig {
   field: string;
-  label?: string;
-  format?: string;
   showAxisTitle?: boolean; // Default is false
+  zeroBasedOrigin?: boolean; // Default is false
   type: "quantitative" | "ordinal" | "nominal" | "temporal";
   timeUnit?: string; // For temporal fields
 }

diff --git a/web-common/src/features/canvas/inspector/PositionalFieldConfig.svelte b/web-common/src/features/canvas/inspector/PositionalFieldConfig.svelte
@@ -73,6 +73,19 @@
         >
           <span class="ml-2">Show axis title</span>
         </DropdownMenu.CheckboxItem>
+        {#if !isDimension}
+          <DropdownMenu.CheckboxItem
+            checked={fieldConfig?.zeroBasedOrigin}
+            on:click={async () => {
+              updateFieldProperty(
+                "zeroBasedOrigin",
+                !fieldConfig?.zeroBasedOrigin,
+              );
+            }}
+          >
+            <span class="ml-2">Zero based origin</span>
+          </DropdownMenu.CheckboxItem>
+        {/if}
       </DropdownMenu.Content>
     </DropdownMenu.Root>
   </div>