Runtime: expand view for external table storage #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
requested changes
Dec 8, 2023
runtime/drivers/duckdb/olap.go
Outdated
| if err := rows.Scan(&col); err != nil { | ||
| return "", err | ||
| } | ||
| cols = append(cols, col) |
There was a problem hiding this comment.
Shouldn't it use safeName for the col? Otherwise, the statement will break if there's a column named e.g. hel"lo
|
The test failures though persistent seems unrelated. |
begelundmuller
approved these changes
Dec 11, 2023
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
* expand view for external table storage * lint fix * duckdb driver complexity list * review comments - use safename for col
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3332 (partially fixes it, to fix it fully is a long term solution)