Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Organization email and plan to init logs #6519

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

grahamplata
Copy link
Contributor

Add Organization email and plan to init logs

Copy link
Contributor

@himadrisingh himadrisingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add info when plan changes?
https://github.com/rilldata/rill-private-issues/issues/1157

  1. Announcement when a customer on prod has activated a free trial
  2. Announcement when a customer on prod has upgraded a free trial to team plan
  3. Announcement when a free trial has 7 days left
  4. Announcement when a free trial has expired
  5. Announcement when a trial grace period has ended and org is hibernated (i.e. free trial ends with no upgrade)

@grahamplata
Copy link
Contributor Author

Absolutely, adding

Verified

This commit was signed with the committer’s verified signature.
squid233 squid233
@grahamplata grahamplata force-pushed the gplata/add-logging-context branch from edaee0a to e6e8b78 Compare January 29, 2025 21:28
@grahamplata grahamplata force-pushed the gplata/add-logging-context branch from e6e8b78 to b40bbb6 Compare January 29, 2025 21:29
admin/billing.go Outdated
Comment on lines 36 to 38
s.Logger.Info("created billing customer",
zap.String("org", org.Name),
zap.String("billing_customer_id", bc.ID),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org_id is missing compared to line #105

Copy link
Contributor

@himadrisingh himadrisingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamplata grahamplata merged commit 97487a0 into main Jan 31, 2025
7 checks passed
@grahamplata grahamplata deleted the gplata/add-logging-context branch January 31, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants