Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upload favicon backend support #6606

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat: Upload favicon backend support #6606

merged 1 commit into from
Feb 10, 2025

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Feb 6, 2025 •
edited
Loading

Supports adding a custom favicon to orgs.

  • Adds favicon_asset_id to UpdateOrganization
  • Adds favicon_url to GetOrganization
  • Adds upload-favicon command mirroring upload-logo
    UI PR to follow.

Ref ticket: #6600

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes (partially)
  • Checked if the docs need to be updated (Will be added as part of overall custom logo support)
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde marked this pull request as ready for review February 6, 2025 15:28
mindspank
mindspank reviewed Feb 6, 2025
View reviewed changes
cli/cmd/org/upload_favicon.go
// Check the file is an image
ext := strings.TrimPrefix(filepath.Ext(path), ".")
switch ext {
case "png", "ico":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add gif, svg and jpg also. Might as well just allow every image type at this point

Copy link
Contributor

@begelundmuller begelundmuller Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that's not supported for favicons. But I can add it for normal logo uploads.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6631

@begelundmuller begelundmuller merged commit fd0878b into main Feb 10, 2025
13 checks passed
@begelundmuller begelundmuller deleted the feat/favicon-upload-backend branch February 10, 2025 14:14
@AdityaHegde AdityaHegde mentioned this pull request Feb 11, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

@mindspank mindspank mindspank left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaHegde @begelundmuller @mindspank