Skip to content

Commit

Permalink
Mark USE_CMAKE as deprecated
Browse files Browse the repository at this point in the history
  • Loading branch information
rillig committed Aug 19, 2024
1 parent 1f77350 commit 56e4dbe
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
3 changes: 3 additions & 0 deletions v23/pkgsrc.go
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,9 @@ func (src *Pkgsrc) initDeprecatedVars() {

// June 2016
"USE_CROSSBASE": "Has been removed.",

// August 2024
"USE_CMAKE": "Include \"../../devel/cmake/build.mk\" instead.",
}
}

Expand Down
11 changes: 8 additions & 3 deletions v23/tools_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -455,9 +455,11 @@ func (s *Suite) Test_Tools__aliases_in_for_loop(c *check.C) {
}

// The cmake tool is included conditionally. The condition is so simple that
// pkglint could parse it but it depends on the particular package.
// pkglint could parse it, but the condition depends on the particular
// package.
//
// This is something that pkglint cannot do right now, since the global tools
// are loaded once for all packages.
// are loaded once for all packages, before inspecting the single package.
//
// Therefore, there is a workaround for USE_CMAKE.
//
Expand All @@ -478,7 +480,10 @@ func (s *Suite) Test_Tools__cmake(c *check.C) {

G.Check(t.File("category/package"))

t.CheckOutputEmpty()
t.CheckOutputLines(
"WARN: ~/category/package/Makefile:20: " +
"Definition of USE_CMAKE is deprecated. " +
"Include \"../../devel/cmake/build.mk\" instead.")
}

func (s *Suite) Test_Tools__gmake(c *check.C) {
Expand Down

0 comments on commit 56e4dbe

Please sign in to comment.