Fix Immunefi Report #31869 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we remove payable as well? https://github.com/msgport/ORMP/blob/main/src/ORMP.sol#L51 |
16 tasks
hackfisher
approved these changes
Jun 3, 2024
This is used for pay fees, should not be removed. |
Do you mean this instead? https://github.com/msgport/ORMP/blob/ed758a04b24fe06db5971909a578087e564bf82d/src/ORMP.sol#L144 |
|
Also do it for tron @hujw77 https://github.com/msgport/ORMP/blob/main/tron/ORMP.f.sol#L523 |
jiguantong
approved these changes
Jun 3, 2024
|
@hujw77 Please also make update here: https://github.com/msgport/ORMP/blob/ed758a04b24fe06db5971909a578087e564bf82d/tron/ORMP.f.sol#L474 |
hackfisher
approved these changes
Jun 3, 2024
xiaoch05
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.