Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORMPUpgradeablePort #218

Merged
merged 40 commits into from
Apr 10, 2024
Merged

ORMPUpgradeablePort #218

merged 40 commits into from
Apr 10, 2024

Conversation

hujw77
Copy link
Contributor

@hujw77 hujw77 commented Mar 12, 2024 •
edited
Loading

@hujw77 hujw77 requested a review from jiguantong March 12, 2024 09:22
@hujw77 hujw77 requested review from hackfisher and xiaoch05 March 13, 2024 03:51
@hujw77 hujw77 marked this pull request as ready for review March 13, 2024 03:51
@hujw77 hujw77 marked this pull request as draft March 13, 2024 14:36
@hujw77 hujw77 marked this pull request as ready for review March 13, 2024 14:39
hackfisher
hackfisher reviewed Mar 15, 2024
View reviewed changes
Copy link

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflicts

@hujw77 hujw77 requested a review from hackfisher March 15, 2024 12:26
@hujw77
Copy link
Contributor Author

hujw77 commented Mar 15, 2024

Please fix the conflicts

Solved.

@hujw77 hujw77 requested a review from hackfisher March 21, 2024 14:51
@jiguantong jiguantong mentioned this pull request Mar 22, 2024
Closed
@hujw77 hujw77 changed the title Fix issues ORMPUpgradeablePort Mar 22, 2024
@hujw77 hujw77 requested a review from jiguantong April 10, 2024 03:29
@hackfisher hackfisher merged commit d24dcf5 into main Apr 10, 2024
2 checks passed
@hujw77 hujw77 deleted the echo/fix branch April 23, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher hackfisher approved these changes

@xiaoch05 xiaoch05 Awaiting requested review from xiaoch05

@jiguantong jiguantong Awaiting requested review from jiguantong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add setORMP interface on ORMPPort
3 participants
@hujw77 @hackfisher @jiguantong