Draft: Implement genserver callbacks #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangdennis
force-pushed
the
dennisdang-genserver-callbacks
branch
from
092038d to
7bee446
Compare
leostera
reviewed
Dec 21, 2023
| @@ -31,6 +33,11 @@ let call : type res. Pid.t -> res req -> res = | |||
| | None -> failwith "bad message") | |||
| | _ -> failwith "unexpected message" | |||
|
|
|||
| let cast : type res. Pid.t -> res req -> unit = | |||
There was a problem hiding this comment.
suggestion. I think we can write this without a locally abstract type since the Cast constructor would already take any type as input.
|
Thanks for contributing @dangdennis! ✨ I'll keep an eye, feel free to ping/tag me if you want comments on anything specific 🙏🏼 |
|
@leostera sorry I won’t have time to finish this for a while. :[ ill close and someone else can pick up the issue later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to resolve #4 myself.
But I'm not done yet. I've only partially implemented handle_cast and cast. I created this PR for potential early feedback and signal that someone's working on the issue.