Make timers cancellable #10 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leostera
reviewed
Dec 31, 2023
leostera
reviewed
Dec 31, 2023
leostera
requested changes
Dec 31, 2023
There was a problem hiding this comment.
Thanks @LeedsJohn for opening this PR! 🙏🏼
Overall it looks great. The test could use a few adjustments, and I think maybe there's a bug in it? Left you some comments!
After we fix this it'd be good to merge 🚀
leostera
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a feature to make timers cancellable.
I added a function to remove a
Timer.tfrom aTimer_wheel.twhich removes thetimerfrom theidsandtimersdashmaps. After this, I addedTimer.canceltoriot.ml(i).I wrote a test that has one timer send messages rapidly and another timer send one message. I immediately cancel the "send_interval" timer and assert that the last received message was the one sent from the second timer.
Let me know if there's any changes you would like for me to make - thanks!